Re: [PATCH v3 09/20] commit-graph: verify corrupt OID fanout and lookup

2018-06-04 Thread Duy Nguyen
On Mon, Jun 4, 2018 at 1:32 PM, Derrick Stolee wrote: > On 6/2/2018 12:38 AM, Duy Nguyen wrote: >> >> On Thu, May 24, 2018 at 6:25 PM, Derrick Stolee >> wrote: >>> >>> + if (i && oidcmp(_oid, _oid) >= 0) >>> + graph_report("commit-graph has incorrect OID >>>

Re: [PATCH v3 09/20] commit-graph: verify corrupt OID fanout and lookup

2018-06-04 Thread Derrick Stolee
On 6/2/2018 12:38 AM, Duy Nguyen wrote: On Thu, May 24, 2018 at 6:25 PM, Derrick Stolee wrote: + if (i && oidcmp(_oid, _oid) >= 0) + graph_report("commit-graph has incorrect OID order: %s then %s", +oid_to_hex(_oid), +

Re: [PATCH v3 09/20] commit-graph: verify corrupt OID fanout and lookup

2018-06-01 Thread Duy Nguyen
On Thu, May 24, 2018 at 6:25 PM, Derrick Stolee wrote: > + if (i && oidcmp(_oid, _oid) >= 0) > + graph_report("commit-graph has incorrect OID order: > %s then %s", > +oid_to_hex(_oid), > +

Re: [PATCH v3 09/20] commit-graph: verify corrupt OID fanout and lookup

2018-05-30 Thread Derrick Stolee
On 5/30/2018 9:34 AM, Jakub Narebski wrote: Derrick Stolee writes: In the commit-graph file, the OID fanout chunk provides an index into the OID lookup. The 'verify' subcommand should find incorrect values in the fanout. Similarly, the 'verify' subcommand should find out-of-order values in

Re: [PATCH v3 09/20] commit-graph: verify corrupt OID fanout and lookup

2018-05-30 Thread Jakub Narebski
Derrick Stolee writes: > In the commit-graph file, the OID fanout chunk provides an index into > the OID lookup. The 'verify' subcommand should find incorrect values > in the fanout. > > Similarly, the 'verify' subcommand should find out-of-order values in > the OID lookup. O.K., the OID Lookup

[PATCH v3 09/20] commit-graph: verify corrupt OID fanout and lookup

2018-05-24 Thread Derrick Stolee
In the commit-graph file, the OID fanout chunk provides an index into the OID lookup. The 'verify' subcommand should find incorrect values in the fanout. Similarly, the 'verify' subcommand should find out-of-order values in the OID lookup. Signed-off-by: Derrick Stolee