Re: [PATCH v3 09/20] range-diff: adjust the output of the commit pairs

2018-07-21 Thread Johannes Schindelin
Hi Stefan, On Fri, 20 Jul 2018, Stefan Beller wrote: > > 1. To roll again. > > > > A player who rolls two sixes can reroll the dice for an additional > > turn. > > This is where I had my AHA moment! > (Consider my software development process as chaotic as a dice roll > So re

Re: [PATCH v3 09/20] range-diff: adjust the output of the commit pairs

2018-07-20 Thread Stefan Beller
> 1. To roll again. > > A player who rolls two sixes can reroll the dice for an additional > turn. This is where I had my AHA moment! (Consider my software development process as chaotic as a dice roll So rerolling is really just rolling the dice again to "get my patch accepted

Re: [PATCH v3 09/20] range-diff: adjust the output of the commit pairs

2018-07-20 Thread Johannes Schindelin
Hi Stefan, On Tue, 17 Jul 2018, Stefan Beller wrote: > > > It's nice to see that the bulk of the range-diff functionality has > > > been libified in this re-roll (residing in range-diff.c rather than > > > > Can we *please* stop calling it "re-roll"? Thanks. > > Fun fact of the day: > > First a

Re: [PATCH v3 09/20] range-diff: adjust the output of the commit pairs

2018-07-17 Thread Stefan Beller
Hi Johannes, > > It's nice to see that the bulk of the range-diff functionality has > > been libified in this re-roll (residing in range-diff.c rather than > > Can we *please* stop calling it "re-roll"? Thanks. Fun fact of the day: First appearance of "reroll" in the public archive is (09 Dec 20

Re: [PATCH v3 09/20] range-diff: adjust the output of the commit pairs

2018-07-17 Thread Johannes Schindelin
Hi Eric, On Mon, 16 Jul 2018, Eric Sunshine wrote: > On Tue, Jul 3, 2018 at 7:26 AM Johannes Schindelin via GitGitGadget > wrote: > > This change brings `git range-diff` yet another step closer to > > feature parity with tbdiff: it now shows the oneline, too, and indicates > > with `=` when the

Re: [PATCH v3 09/20] range-diff: adjust the output of the commit pairs

2018-07-16 Thread Eric Sunshine
On Tue, Jul 3, 2018 at 7:26 AM Johannes Schindelin via GitGitGadget wrote: > This change brings `git range-diff` yet another step closer to > feature parity with tbdiff: it now shows the oneline, too, and indicates > with `=` when the commits have identical diffs. > > Signed-off-by: Johannes Schin

[PATCH v3 09/20] range-diff: adjust the output of the commit pairs

2018-07-03 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This change brings `git range-diff` yet another step closer to feature parity with tbdiff: it now shows the oneline, too, and indicates with `=` when the commits have identical diffs. Signed-off-by: Johannes Schindelin --- range-diff.c | 66 +++