Re: [PATCH v3 09/23] cat-file: start use ref_array_item struct

2018-02-15 Thread Оля Тележная
2018-02-15 8:40 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Moving from using expand_data to ref_array_item structure. >> That helps us to reuse functions from ref-filter easier. > > This one feels weird. The point of a

Re: [PATCH v3 09/23] cat-file: start use ref_array_item struct

2018-02-14 Thread Jeff King
On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > Moving from using expand_data to ref_array_item structure. > That helps us to reuse functions from ref-filter easier. This one feels weird. The point of a ref_array_item is for the caller to feed data into the ref-filter

[PATCH v3 09/23] cat-file: start use ref_array_item struct

2018-02-12 Thread Olga Telezhnaya
Moving from using expand_data to ref_array_item structure. That helps us to reuse functions from ref-filter easier. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King --- builtin/cat-file.c |