Hi,
Dave Borowitz wrote:
curl-config is usually installed alongside a curl distribution, and
its purpose is to provide flags for building against libcurl, so use
it instead of guessing flags and dependent libraries.
The previous version of these two patches is already part of master.
Could
Dave Borowitz dborow...@google.com writes:
Use this only when CURLDIR is not explicitly specified, to continue
supporting older builds. Moreover, if CURL_CONFIG is unset or running
it returns no results (e.g. because it is missing), default to the old
behavior of blindly setting -lcurl.
On Mon, Apr 28, 2014 at 12:44 PM, Jonathan Nieder jrnie...@gmail.com wrote:
Hi,
Dave Borowitz wrote:
curl-config is usually installed alongside a curl distribution, and
its purpose is to provide flags for building against libcurl, so use
it instead of guessing flags and dependent libraries.
Junio C Hamano gits...@pobox.com writes:
That does not mean the patch will give us a broken behaviour,
though. It just means the ifeq/else part will be redundant.
endif
+
+ifeq $(CURL_LIBCURL)
This will catch the $(shell $(CURL_CONFIG) --libs) assigned an
empty string to
Junio C Hamano gits...@pobox.com writes:
This ifeq is redundant and will never set CURL_LIBCURL to empty
without running the else part, I think. In a Makefile, a variable
explicitly set to empty and a variable that is unset are treated the
same
$ make -f Makefile CURL_CONFIG=
5 matches
Mail list logo
