Re: [PATCH v3 1/3] lockfile.c: remove PATH_MAX limitation (except in resolve_symlink)

On 08/04/2014 03:13 AM, Duy Nguyen wrote: On Sun, Aug 3, 2014 at 1:13 AM, Torsten Bögershausen tbo...@web.de wrote: [...] My first impression reading this patch was to rename clear_filename() into free_and_clear_filename() or better free_filename(), but I never pressed the send button ;-)

Re: [PATCH v3 1/3] lockfile.c: remove PATH_MAX limitation (except in resolve_symlink)

On Sun, Aug 3, 2014 at 1:13 AM, Torsten Bögershausen tbo...@web.de wrote: On 08/01/2014 07:55 PM, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com Somewhat underexplained,

Re: [PATCH v3 1/3] lockfile.c: remove PATH_MAX limitation (except in resolve_symlink)

Duy Nguyen pclo...@gmail.com writes: I didn't realize Mike is making a lot more changes in lockfile.c, part of that is converting lk-filename to use strbuf [1]. Perhaps I should just withdraw this series, wait until Mike's series is merged, then redo 3/3 on top. Or Mike could just take 3/3 in

Re: [PATCH v3 1/3] lockfile.c: remove PATH_MAX limitation (except in resolve_symlink)

On 08/01/2014 07:55 PM, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com Somewhat underexplained, given that it seems to add some new semantics. +static void

Re: [PATCH v3 1/3] lockfile.c: remove PATH_MAX limitation (except in resolve_symlink)

Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com Somewhat underexplained, given that it seems to add some new semantics. +static void clear_filename(struct lock_file *lk) +{ + free(lk-filename); + lk-filename = NULL; +} It is

Re: [PATCH v3 1/3] lockfile.c: remove PATH_MAX limitation (except in resolve_symlink)

Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: diff --git a/lockfile.c b/lockfile.c index 8fbcb6a..968b28f 100644 --- a/lockfile.c +++ b/lockfile.c @@ -7,13 +7,19 @@ static struct lock_file *lock_file_list; static const char *alternate_index_output; +static void

Re: [PATCH v3 1/3] lockfile.c: remove PATH_MAX limitation (except in resolve_symlink)

Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com Somewhat underexplained, given that it seems to add some new semantics. +static void clear_filename(struct lock_file *lk) +{ +

[PATCH v3 1/3] lockfile.c: remove PATH_MAX limitation (except in resolve_symlink)

Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- cache.h| 2 +- lockfile.c | 56 2 files changed, 33 insertions(+), 25 deletions(-) diff --git a/cache.h b/cache.h index cc46be4..0d8dce7 100644 --- a/cache.h +++ b/cache.h @@