Re: [PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail

2016-03-20 Thread Stefan Beller
On 20.03.2016 12:40, Jeff King wrote: > On Sun, Mar 20, 2016 at 06:05:34PM +0100, Lars Schneider wrote: > +test_expect_failure shallow-clone-recursive ' + URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" && >>> >>> This would break if the test suite is in a path containing any

Re: [PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail

2016-03-20 Thread Jeff King
On Sun, Mar 20, 2016 at 06:05:34PM +0100, Lars Schneider wrote: > >> +test_expect_failure shallow-clone-recursive ' > >> + URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" && > > > > This would break if the test suite is in a path containing any other white > > space > > than U+0020 su

Re: [PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail

2016-03-20 Thread Lars Schneider
On 15 Mar 2016, at 20:50, Stefan Beller wrote: > On Sun, Dec 20, 2015 at 3:19 PM, wrote: >> From: Lars Schneider >> >> "git clone --recursive --depth 1 --single-branch " clones the >> submodules successfully. However, it does not obey "--depth 1" for >> submodule cloning. > > I am about to

Re: [PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail

2016-03-15 Thread Junio C Hamano
Stefan Beller writes: >> +test_expect_failure shallow-clone-recursive ' >> + URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" && > > This would break if the test suite is in a path containing any other white > space > than U+0020 such as a tab? (Not that I am encouraging using such pat

Re: [PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail

2016-03-15 Thread Stefan Beller
On Sun, Dec 20, 2015 at 3:19 PM, wrote: > From: Lars Schneider > > "git clone --recursive --depth 1 --single-branch " clones the > submodules successfully. However, it does not obey "--depth 1" for > submodule cloning. I am about to resend "[RFC/PATCH] clone: add `--shallow-submodules` flag" wh

[PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail

2015-12-20 Thread larsxschneider
From: Lars Schneider "git clone --recursive --depth 1 --single-branch " clones the submodules successfully. However, it does not obey "--depth 1" for submodule cloning. Signed-off-by: Lars Schneider --- t/t7412-submodule-recursive.sh | 52 ++ 1 file chan