Re: [PATCH v3 1/6] alias.c: replace `git_config()` with `git_config_get_string()`

2014-07-31 Thread Samuel Bronson
Ramsay Jones writes: > On 21/07/14 12:12, Tanay Abhra wrote: >> -char *alias_lookup(const char *alias) >> +char *alias_lookup(const char* alias) > > No, this is not C++. :-D Why would C++ make a difference? Shouldn't you *never* do that? -- Hi! I'm a .signature virus! Copy me into your ~/.sign

Re: [PATCH v3 1/6] alias.c: replace `git_config()` with `git_config_get_string()`

2014-07-21 Thread Ramsay Jones
On 21/07/14 12:12, Tanay Abhra wrote: > Use `git_config_get_string()` instead of `git_config()` to take advantage of > the config-set API which provides a cleaner control flow. > The function now raises an error instead of dying when a NULL value is found. > > Signed-off-by: Tanay Abhra > --- >

Re: [PATCH v3 1/6] alias.c: replace `git_config()` with `git_config_get_string()`

2014-07-21 Thread Matthieu Moy
Tanay Abhra writes: > --- a/alias.c > +++ b/alias.c > @@ -1,26 +1,13 @@ > #include "cache.h" > > -static const char *alias_key; > -static char *alias_val; > - > -static int alias_lookup_cb(const char *k, const char *v, void *cb) > -{ > - const char *name; > - if (skip_prefix(k, "alias.

[PATCH v3 1/6] alias.c: replace `git_config()` with `git_config_get_string()`

2014-07-21 Thread Tanay Abhra
Use `git_config_get_string()` instead of `git_config()` to take advantage of the config-set API which provides a cleaner control flow. The function now raises an error instead of dying when a NULL value is found. Signed-off-by: Tanay Abhra --- alias.c | 27 +++ 1 file cha