Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-06 Thread Junio C Hamano
Adam Spiers writes: > That's a valid point. However, the ary[0] part which assumes external > knowledge of the internal implementation can trivially be avoided by > squashing this patch onto the commit we are discussing: > > diff --git a/builtin/clean.c b/builtin/clean.c > index dd89737..6e21ca6

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-06 Thread Adam Spiers
On Sun, Jan 06, 2013 at 10:53:11PM +, Adam Spiers wrote: > That's a valid point. However, the ary[0] part which assumes external > knowledge of the internal implementation can trivially be avoided by > squashing this patch onto the commit we are discussing: [snipped] > diff --git a/builtin/l

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-06 Thread Adam Spiers
On Sun, Jan 06, 2013 at 12:25:48PM -0800, Junio C Hamano wrote: > Adam Spiers writes: > > > On Fri, Jan 04, 2013 at 01:03:59PM -0800, Junio C Hamano wrote: > >> Adam Spiers writes: > >> > >> > diff --git a/builtin/clean.c b/builtin/clean.c > >> > index 0c7b3d0..bd18b88 100644 > >> > --- a/built

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-06 Thread Junio C Hamano
Adam Spiers writes: > On Fri, Jan 04, 2013 at 01:03:59PM -0800, Junio C Hamano wrote: >> Adam Spiers writes: >> >> > diff --git a/builtin/clean.c b/builtin/clean.c >> > index 0c7b3d0..bd18b88 100644 >> > --- a/builtin/clean.c >> > +++ b/builtin/clean.c >> > @@ -97,9 +97,10 @@ int cmd_clean(int

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-06 Thread Adam Spiers
On Fri, Jan 04, 2013 at 11:54:34PM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > Adam Spiers writes: > > > >> diff --git a/builtin/clean.c b/builtin/clean.c > >> index 0c7b3d0..bd18b88 100644 > >> --- a/builtin/clean.c > >> +++ b/builtin/clean.c > >> @@ -97,9 +97,10 @@ int cmd_clean(i

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-06 Thread Adam Spiers
On Fri, Jan 04, 2013 at 01:03:59PM -0800, Junio C Hamano wrote: > Adam Spiers writes: > > > diff --git a/builtin/clean.c b/builtin/clean.c > > index 0c7b3d0..bd18b88 100644 > > --- a/builtin/clean.c > > +++ b/builtin/clean.c > > @@ -97,9 +97,10 @@ int cmd_clean(int argc, const char **argv, const

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-04 Thread Junio C Hamano
Junio C Hamano writes: > Adam Spiers writes: > >> diff --git a/builtin/clean.c b/builtin/clean.c >> index 0c7b3d0..bd18b88 100644 >> --- a/builtin/clean.c >> +++ b/builtin/clean.c >> @@ -97,9 +97,10 @@ int cmd_clean(int argc, const char **argv, const char >> *prefix) >> if (!ignored) >>

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-04 Thread Junio C Hamano
Adam Spiers writes: > diff --git a/builtin/clean.c b/builtin/clean.c > index 0c7b3d0..bd18b88 100644 > --- a/builtin/clean.c > +++ b/builtin/clean.c > @@ -97,9 +97,10 @@ int cmd_clean(int argc, const char **argv, const char > *prefix) > if (!ignored) > setup_standard_excludes

[PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2012-12-26 Thread Adam Spiers
Previously each exclude_list could potentially contain patterns from multiple sources. For example dir->exclude_list[EXC_FILE] would typically contain patterns from .git/info/exclude and core.excludesfile, and dir->exclude_list[EXC_DIRS] could contain patterns from multiple per-directory .gitignor