Re: [PATCH v3 12/25] sequencer: remember the onelines when parsing the todo file

Hi Junio, On Wed, 12 Oct 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> > +const char *arg; > >> > +int arg_len; > >> > size_t offset_in_buf; > >> > >> micronit: you can make it to size_t and lose the cast below, no? > > >

Re: [PATCH v3 12/25] sequencer: remember the onelines when parsing the todo file

Johannes Schindelin writes: >> > + const char *arg; >> > + int arg_len; >> >size_t offset_in_buf; >> >> micronit: you can make it to size_t and lose the cast below, no? > > No. The primary users of arg_len call a printf() style function with %.*s, > expecting

Re: [PATCH v3 12/25] sequencer: remember the onelines when parsing the todo file

Hi Junio, On Tue, 11 Oct 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > diff --git a/sequencer.c b/sequencer.c > > index afc494e..7ba5e07 100644 > > --- a/sequencer.c > > +++ b/sequencer.c > > @@ -708,6 +708,8 @@ static int

Re: [PATCH v3 12/25] sequencer: remember the onelines when parsing the todo file

Johannes Schindelin writes: > The `git-rebase-todo` file contains a list of commands. Most of those > commands have the form > > > > The is displayed primarily for the user's convenience, as > rebase -i really interprets only the part. However, there > are

[PATCH v3 12/25] sequencer: remember the onelines when parsing the todo file

The `git-rebase-todo` file contains a list of commands. Most of those commands have the form The is displayed primarily for the user's convenience, as rebase -i really interprets only the part. However, there are *some* places in interactive rebase where the is used to display