Re: [PATCH v3 16/23] ref-filter: make cat_file_info independent

2018-02-16 Thread Jeff King
On Thu, Feb 15, 2018 at 01:33:25PM +0300, Оля Тележная wrote: > 2018-02-15 8:53 GMT+03:00 Jeff King : > > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > > > >> Remove connection between expand_data variable > >> in cat-file and in ref-filter. > >> It will help

Re: [PATCH v3 16/23] ref-filter: make cat_file_info independent

2018-02-15 Thread Оля Тележная
2018-02-15 8:53 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Remove connection between expand_data variable >> in cat-file and in ref-filter. >> It will help further to get rid of using expand_data in cat-file. > > I have to admit I'm

Re: [PATCH v3 16/23] ref-filter: make cat_file_info independent

2018-02-14 Thread Jeff King
On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > Remove connection between expand_data variable > in cat-file and in ref-filter. > It will help further to get rid of using expand_data in cat-file. I have to admit I'm confused at this point about what is_cat_file is for, or even

[PATCH v3 16/23] ref-filter: make cat_file_info independent

2018-02-12 Thread Olga Telezhnaya
Remove connection between expand_data variable in cat-file and in ref-filter. It will help further to get rid of using expand_data in cat-file. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King