Re: [PATCH v3 18/19] setup.c: document get_pathspec()

2012-12-28 Thread Junio C Hamano
Adam Spiers writes: > I've added this sentence to the top of the comments above > get_pathspec(): > > /* > * N.B. get_pathspec() is deprecated in favor of the "struct pathspec" > * based interface - see pathspec_magic above. > * > [...] > > That should be sufficient to disc

Re: [PATCH v3 18/19] setup.c: document get_pathspec()

2012-12-28 Thread Adam Spiers
On Fri, Dec 28, 2012 at 8:40 PM, Adam Spiers wrote: > On Fri, Dec 28, 2012 at 8:36 PM, Junio C Hamano wrote: >> Adam Spiers writes: >> >>> Since we have just created a new pathspec-handling library, now is a >>> good time to add some comments explaining get_pathspec(). >>> >>> Signed-off-by: Ada

Re: [PATCH v3 18/19] setup.c: document get_pathspec()

2012-12-28 Thread Adam Spiers
On Fri, Dec 28, 2012 at 8:36 PM, Junio C Hamano wrote: > Adam Spiers writes: > >> Since we have just created a new pathspec-handling library, now is a >> good time to add some comments explaining get_pathspec(). >> >> Signed-off-by: Adam Spiers >> --- > > Yes, but we would rather not to see new

Re: [PATCH v3 18/19] setup.c: document get_pathspec()

2012-12-28 Thread Junio C Hamano
Adam Spiers writes: > Since we have just created a new pathspec-handling library, now is a > good time to add some comments explaining get_pathspec(). > > Signed-off-by: Adam Spiers > --- Yes, but we would rather not to see new users of this function added to our codebase in its current form, a

[PATCH v3 18/19] setup.c: document get_pathspec()

2012-12-26 Thread Adam Spiers
Since we have just created a new pathspec-handling library, now is a good time to add some comments explaining get_pathspec(). Signed-off-by: Adam Spiers --- setup.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/setup.c b/setup.c index 7663a4c..03d6d5c 100644 --- a/setup.c