Re: [PATCH v3 2/2] http: fix the silent ignoring of proxy misconfiguraion

2017-04-11 Thread Sergey Ryazanov
On Tue, Apr 11, 2017 at 8:37 PM, Jeff King wrote: > On Tue, Apr 11, 2017 at 08:17:50PM +0300, Sergey Ryazanov wrote: >> Earlier, the whole http.proxy option string was passed to curl without >> any preprocessing so curl could complain about the invalid proxy >> configuration. >> >> After the commi

Re: [PATCH v3 2/2] http: fix the silent ignoring of proxy misconfiguraion

2017-04-11 Thread Jeff King
On Tue, Apr 11, 2017 at 08:17:50PM +0300, Sergey Ryazanov wrote: > Earlier, the whole http.proxy option string was passed to curl without > any preprocessing so curl could complain about the invalid proxy > configuration. > > After the commit 372370f167 ("http: use credential API to handle proxy

[PATCH v3 2/2] http: fix the silent ignoring of proxy misconfiguraion

2017-04-11 Thread Sergey Ryazanov
Earlier, the whole http.proxy option string was passed to curl without any preprocessing so curl could complain about the invalid proxy configuration. After the commit 372370f167 ("http: use credential API to handle proxy authentication", 2016-01-26), if the user specified an invalid HTTP proxy op