Re: [PATCH v3 2/2] range-diff: fix regression in passing along diff options

2018-11-08 Thread Ævar Arnfjörð Bjarmason
On Fri, Nov 09 2018, Eric Sunshine wrote: > On Thu, Nov 8, 2018 at 5:34 PM Ævar Arnfjörð Bjarmason > wrote: >> On Thu, Nov 08 2018, Eric Sunshine wrote: >> > Looking at diff.c:parse_diff_opt() and enable_patch_output(), rather >> > than introducing this new conditional, I'm thinking that a

Re: [PATCH v3 2/2] range-diff: fix regression in passing along diff options

2018-11-08 Thread Eric Sunshine
On Thu, Nov 8, 2018 at 5:34 PM Ævar Arnfjörð Bjarmason wrote: > On Thu, Nov 08 2018, Eric Sunshine wrote: > > Looking at diff.c:parse_diff_opt() and enable_patch_output(), rather > > than introducing this new conditional, I'm thinking that a more > > correct fix would be: > > > >

Re: [PATCH v3 2/2] range-diff: fix regression in passing along diff options

2018-11-08 Thread Ævar Arnfjörð Bjarmason
On Thu, Nov 08 2018, Eric Sunshine wrote: > On Wed, Nov 7, 2018 at 7:22 AM Ævar Arnfjörð Bjarmason > wrote: >> In 73a834e9e2 ("range-diff: relieve callers of low-level configuration >> burden", 2018-07-22) we broke passing down options like --no-patch, >> --stat etc. Fix that regression, and

Re: [PATCH v3 2/2] range-diff: fix regression in passing along diff options

2018-11-08 Thread Eric Sunshine
On Wed, Nov 7, 2018 at 7:22 AM Ævar Arnfjörð Bjarmason wrote: > In 73a834e9e2 ("range-diff: relieve callers of low-level configuration > burden", 2018-07-22) we broke passing down options like --no-patch, > --stat etc. Fix that regression, and add a test for some of these > options being passed

[PATCH v3 2/2] range-diff: fix regression in passing along diff options

2018-11-07 Thread Ævar Arnfjörð Bjarmason
In 73a834e9e2 ("range-diff: relieve callers of low-level configuration burden", 2018-07-22) we broke passing down options like --no-patch, --stat etc. Fix that regression, and add a test for some of these options being passed down. As noted in a change leading up to this ("range-diff doc: add a