Re: [PATCH v3 2/2] rebase-i: work around Windows CRLF line endings

2015-10-28 Thread Johannes Schindelin
Hi Junio, On Tue, 27 Oct 2015, Junio C Hamano wrote: > Johannes Schindelin writes: > > > My apologies: I forgot to spell out explicitly that this passes in Git > > for Windows 2.x' SDK: It does. > > Can you add that to the log message? Your cover letter may also

[PATCH v3 2/2] rebase-i: work around Windows CRLF line endings

2015-10-27 Thread Johannes Schindelin
From: Junio C Hamano Editors on Windows can and do save text files with CRLF line endings, which is the convention on the platform. We are seeing reports that the "read" command in a port of bash to the environment however does not strip the CRLF at the end, not adjusting for

Re: [PATCH v3 2/2] rebase-i: work around Windows CRLF line endings

2015-10-27 Thread Johannes Schindelin
Hi, On Tue, 27 Oct 2015, Johannes Schindelin wrote: > diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh > index 5dfa16a..98eb49a 100755 > --- a/t/t3404-rebase-interactive.sh > +++ b/t/t3404-rebase-interactive.sh > @@ -1261,7 +1261,7 @@ test_expect_success 'static check

Re: [PATCH v3 2/2] rebase-i: work around Windows CRLF line endings

2015-10-27 Thread Junio C Hamano
Johannes Schindelin writes: > On Tue, 27 Oct 2015, Johannes Schindelin wrote: > >> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh >> index 5dfa16a..98eb49a 100755 >> --- a/t/t3404-rebase-interactive.sh >> +++ b/t/t3404-rebase-interactive.sh