Re: [PATCH v3 2/2] setup: don't fail if commondir reference is deleted.

2019-02-21 Thread Michal Suchánek
On Wed, 20 Feb 2019 13:35:57 -0500 Eric Sunshine wrote: > On Wed, Feb 20, 2019 at 12:16 PM Michal Suchánek wrote: > > On Wed, 20 Feb 2019 11:55:46 -0500 > > Eric Sunshine wrote: > > > Following this change, that particular validation no longer takes > > > place. But, more importantly, what d

Re: [PATCH v3 2/2] setup: don't fail if commondir reference is deleted.

2019-02-21 Thread Michal Suchánek
On Thu, 21 Feb 2019 04:27:21 -0500 Eric Sunshine wrote: > On Wed, Feb 20, 2019 at 1:35 PM Eric Sunshine wrote: > > On Wed, Feb 20, 2019 at 12:16 PM Michal Suchánek wrote: > > > > > On Wed, 20 Feb 2019 11:55:46 -0500 > > > Eric Sunshine wrote: > > > > On Wed, Feb 20, 2019 at 11:17 AM Micha

Re: [PATCH v3 2/2] setup: don't fail if commondir reference is deleted.

2019-02-21 Thread Eric Sunshine
On Wed, Feb 20, 2019 at 1:35 PM Eric Sunshine wrote: > On Wed, Feb 20, 2019 at 12:16 PM Michal Suchánek wrote: > > On Wed, 20 Feb 2019 11:55:46 -0500 > > Eric Sunshine wrote: > > > On Wed, Feb 20, 2019 at 11:17 AM Michal Suchanek > > > wrote: > > > > Another even rarer issue is that the file m

Re: [PATCH v3 2/2] setup: don't fail if commondir reference is deleted.

2019-02-20 Thread Eric Sunshine
On Wed, Feb 20, 2019 at 12:16 PM Michal Suchánek wrote: > On Wed, 20 Feb 2019 11:55:46 -0500 > Eric Sunshine wrote: > > On Wed, Feb 20, 2019 at 11:17 AM Michal Suchanek wrote: > > > Apparently it can happen that stat() claims there is a commondir file but > > > when > > > trying to open the fil

Re: [PATCH v3 2/2] setup: don't fail if commondir reference is deleted.

2019-02-20 Thread Michal Suchánek
On Wed, 20 Feb 2019 11:55:46 -0500 Eric Sunshine wrote: > On Wed, Feb 20, 2019 at 11:17 AM Michal Suchanek wrote: > > Apparently it can happen that stat() claims there is a commondir file but > > when > > trying to open the file it is missing. > > Under what circumstances? I would like to k

Re: [PATCH v3 2/2] setup: don't fail if commondir reference is deleted.

2019-02-20 Thread Eric Sunshine
On Wed, Feb 20, 2019 at 11:17 AM Michal Suchanek wrote: > Apparently it can happen that stat() claims there is a commondir file but when > trying to open the file it is missing. Under what circumstances? > Another even rarer issue is that the file might be zero size because another > process ini

[PATCH v3 2/2] setup: don't fail if commondir reference is deleted.

2019-02-20 Thread Michal Suchanek
Apparently it can happen that stat() claims there is a commondir file but when trying to open the file it is missing. Another even rarer issue is that the file might be zero size because another process initializing a worktree opened the file but has not written is content yet. When any of this h