Re: [PATCH v3 2/3] refs/files-backend: fix memory leak in lock_ref_for_update

2017-09-05 Thread Martin Ågren
On 5 September 2017 at 10:47, Jeff King wrote: > On Tue, Aug 29, 2017 at 07:18:23PM +0200, Martin Ågren wrote: > >> After the previous patch, none of the functions we call hold on to >> `referent.buf`, so we can safely release the string buffer before >> returning. > > I ended up

Re: [PATCH v3 2/3] refs/files-backend: fix memory leak in lock_ref_for_update

2017-09-05 Thread Jeff King
On Tue, Aug 29, 2017 at 07:18:23PM +0200, Martin Ågren wrote: > After the previous patch, none of the functions we call hold on to > `referent.buf`, so we can safely release the string buffer before > returning. I ended up doing this a little differently in my version: diff --git

[PATCH v3 2/3] refs/files-backend: fix memory leak in lock_ref_for_update

2017-08-29 Thread Martin Ågren
After the previous patch, none of the functions we call hold on to `referent.buf`, so we can safely release the string buffer before returning. Signed-off-by: Martin Ågren --- v3: identical to v2 refs/files-backend.c | 31 --- 1 file changed,