Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-24 Thread Junio C Hamano
Duy Nguyen writes: > OK. Just to be sure we're on the same page. Am I waiting for all > config changes to land in 'master', or do I rebase my series on > 'next'? I usually base on 'master' but the mention of 'next' here > confuses me a bit. I was hoping that you can do something like: $ git

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-24 Thread Duy Nguyen
On Wed, Oct 24, 2018 at 4:56 AM Junio C Hamano wrote: > How we should get there is a different story. I think Duy's series > needs at least another update to move the split pieces into its own > subdirectory of Documentation/, and it is not all that urgent, while > this three-patch series (with

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-24 Thread Duy Nguyen
On Tue, Oct 23, 2018 at 8:47 PM Ben Peart wrote: > > > > On 10/22/2018 10:45 AM, Duy Nguyen wrote: > > On Mon, Oct 22, 2018 at 3:38 PM Ben Peart wrote: > >> > >> From: Ben Peart > >> > >> Add a reset.quiet config setting that sets the default value of the --quiet > >> flag when running the

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-24 Thread Junio C Hamano
Junio C Hamano writes: >> Seems a bit overkill to pull a line of documentation into a separate >> file and replace it with a line of 'import' logic. Perhaps if/when >> there is more documentation to pull out that would make more sense. > > This change (ehh, rather, perhaps nd/config-split

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-23 Thread Junio C Hamano
Ben Peart writes: >>> diff --git a/Documentation/config.txt b/Documentation/config.txt >>> index f6f4c21a54..a2d1b8b116 100644 >>> --- a/Documentation/config.txt >>> +++ b/Documentation/config.txt >>> @@ -2728,6 +2728,9 @@ rerere.enabled:: >>> `$GIT_DIR`, e.g. if "rerere" was previously

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-23 Thread Ben Peart
On 10/22/2018 10:45 AM, Duy Nguyen wrote: On Mon, Oct 22, 2018 at 3:38 PM Ben Peart wrote: From: Ben Peart Add a reset.quiet config setting that sets the default value of the --quiet flag when running the reset command. This enables users to change the default behavior to take advantage

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-23 Thread Jeff King
On Tue, Oct 23, 2018 at 01:31:58PM -0400, Ben Peart wrote: > On 10/22/2018 4:06 PM, Jeff King wrote: > > On Mon, Oct 22, 2018 at 08:13:32PM +0100, Ramsay Jones wrote: > > > > > > -q:: > > > > --quiet:: > > > > - Be quiet, only report errors. > > > > +--no-quiet:: > > > > + Be

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-23 Thread Ben Peart
On 10/22/2018 4:06 PM, Jeff King wrote: On Mon, Oct 22, 2018 at 08:13:32PM +0100, Ramsay Jones wrote: -q:: --quiet:: - Be quiet, only report errors. +--no-quiet:: + Be quiet, only report errors. The default behavior respects the + `reset.quiet` config option, or

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-22 Thread Jeff King
On Mon, Oct 22, 2018 at 08:13:32PM +0100, Ramsay Jones wrote: > > -q:: > > --quiet:: > > - Be quiet, only report errors. > > +--no-quiet:: > > + Be quiet, only report errors. The default behavior respects the > > + `reset.quiet` config option, or `--no-quiet` if that is not set. > >

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-22 Thread Ramsay Jones
On 22/10/2018 14:18, Ben Peart wrote: > From: Ben Peart > > Add a reset.quiet config setting that sets the default value of the --quiet > flag when running the reset command. This enables users to change the > default behavior to take advantage of the performance advantages of > avoiding the

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-22 Thread Duy Nguyen
On Mon, Oct 22, 2018 at 3:38 PM Ben Peart wrote: > > From: Ben Peart > > Add a reset.quiet config setting that sets the default value of the --quiet > flag when running the reset command. This enables users to change the > default behavior to take advantage of the performance advantages of >

[PATCH v3 2/3] reset: add new reset.quiet config setting

2018-10-22 Thread Ben Peart
From: Ben Peart Add a reset.quiet config setting that sets the default value of the --quiet flag when running the reset command. This enables users to change the default behavior to take advantage of the performance advantages of avoiding the scan for unstaged changes after reset. Defaults to