Re: [PATCH v3 2/3] shallow: offer to prune only non-existing entries

2018-10-29 Thread Johannes Schindelin
Hi Jonathan, On Fri, 26 Oct 2018, Jonathan Tan wrote: > > So even better would be to use `is_promisor_object(oid) || > > has_object_file(oid)`, right? > > > > This is something that is probably not even needed: as I mentioned, > > the shallow commits are *expected* to be local. It should not

Re: [PATCH v3 2/3] shallow: offer to prune only non-existing entries

2018-10-26 Thread Jonathan Tan
> Thanks for confirming. > > So even better would be to use `is_promisor_object(oid) || > has_object_file(oid)`, right? > > This is something that is probably not even needed: as I mentioned, the > shallow commits are *expected* to be local. It should not ever happen that > they are fetched.

Re: [PATCH v3 2/3] shallow: offer to prune only non-existing entries

2018-10-26 Thread Johannes Schindelin
Hi Jonathan, On Thu, 25 Oct 2018, Jonathan Tan wrote: > > On Wed, 24 Oct 2018, Johannes Schindelin wrote: > > > > Coming back to my question whether there is a better way to check for > > the presence of a local commit, I figured that I can use > > `has_object_file()` instead of looking up and

Re: [PATCH v3 2/3] shallow: offer to prune only non-existing entries

2018-10-25 Thread Jonathan Tan
> On Wed, 24 Oct 2018, Johannes Schindelin wrote: > > > On Wed, 24 Oct 2018, Junio C Hamano wrote: > > > > > Jonathan, do you see any issues with the use of lookup_commit() in > > > this change wrt lazy clone? I am wondering what happens when the > > > commit in question is at, an immediate

Re: [PATCH v3 2/3] shallow: offer to prune only non-existing entries

2018-10-24 Thread Johannes Schindelin
Hi, On Wed, 24 Oct 2018, Johannes Schindelin wrote: > On Wed, 24 Oct 2018, Junio C Hamano wrote: > > > Jonathan, do you see any issues with the use of lookup_commit() in > > this change wrt lazy clone? I am wondering what happens when the > > commit in question is at, an immediate parent of,

Re: [PATCH v3 2/3] shallow: offer to prune only non-existing entries

2018-10-24 Thread Johannes Schindelin
Hi Junio & Jonathan, On Wed, 24 Oct 2018, Junio C Hamano wrote: > Jonathan, do you see any issues with the use of lookup_commit() in > this change wrt lazy clone? I am wondering what happens when the > commit in question is at, an immediate parent of, or an immediate > child of a promisor

Re: [PATCH v3 2/3] shallow: offer to prune only non-existing entries

2018-10-23 Thread Junio C Hamano
Jonathan, do you see any issues with the use of lookup_commit() in this change wrt lazy clone? I am wondering what happens when the commit in question is at, an immediate parent of, or an immediate child of a promisor object. I _think_ this change won't make it worse for two features in playing

[PATCH v3 2/3] shallow: offer to prune only non-existing entries

2018-10-22 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The `prune_shallow()` function wants a full reachability check to be completed before it goes to work, to ensure that all unreachable entries are removed from the shallow file. However, in the upcoming patch we do not even want to go that far. We really only need to