Re: [PATCH v3 2/4] fetch-pack: prepare updated shallow file before fetching the pack

2013-05-25 Thread Duy Nguyen
On Tue, May 7, 2013 at 10:59 PM, Junio C Hamano gits...@pobox.com wrote: if (args-depth 0) { + struct stat st; + if (!fstat(shallow_lock.fd, st) + st.st_size == 0) { + unlink_or_warn(git_path(shallow)); Are we unlinking the

Re: [PATCH v3 2/4] fetch-pack: prepare updated shallow file before fetching the pack

2013-05-07 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: index-pack --strict looks up and follows parent commits. If shallow information is not ready by the time index-pack is run, index-pack may be lead to non-existent objects. Make fetch-pack save shallow file to disk before invoking index-pack.

[PATCH v3 2/4] fetch-pack: prepare updated shallow file before fetching the pack

2013-05-03 Thread Nguyễn Thái Ngọc Duy
index-pack --strict looks up and follows parent commits. If shallow information is not ready by the time index-pack is run, index-pack may be lead to non-existent objects. Make fetch-pack save shallow file to disk before invoking index-pack. git learns new global option --shallow-file to pass on

Re: [PATCH v3 2/4] fetch-pack: prepare updated shallow file before fetching the pack

2013-05-03 Thread Eric Sunshine
On Fri, May 3, 2013 at 8:35 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: index-pack --strict looks up and follows parent commits. If shallow information is not ready by the time index-pack is run, index-pack may be lead to non-existent objects. Make fetch-pack save shallow file to