Re: [PATCH v3 2/5] stash: convert apply to builtin

2018-03-27 Thread Joel Teichroeb
On Tue, Mar 27, 2018 at 9:02 AM, Johannes Schindelin wrote: > Hi Joel, > > [...] >> + >> +static int do_apply_stash(const char *prefix, struct stash_info *info, int >> index) >> +{ >> + struct merge_options o; >> + struct object_id c_tree; >> + struct

Re: [PATCH v3 2/5] stash: convert apply to builtin

2018-03-27 Thread Johannes Schindelin
Hi Joel, On Mon, 26 Mar 2018, Joel Teichroeb wrote: > Add a bulitin helper for performing stash commands. Converting > all at once proved hard to review, so starting with just apply > let conversion get started without the other command being > finished. > > The helper is being implemented as a

Re: [PATCH v3 2/5] stash: convert apply to builtin

2018-03-27 Thread Johannes Schindelin
Hi Joel, On Mon, 26 Mar 2018, Joel Teichroeb wrote: > Add a bulitin helper for performing stash commands. Converting > all at once proved hard to review, so starting with just apply > let conversion get started without the other command being > finished. > > The helper is being implemented as a

[PATCH v3 2/5] stash: convert apply to builtin

2018-03-26 Thread Joel Teichroeb
Add a bulitin helper for performing stash commands. Converting all at once proved hard to review, so starting with just apply let conversion get started without the other command being finished. The helper is being implemented as a drop in replacement for stash so that when it is complete it can