On 02/27, Stefan Beller wrote:
> > +
> > + /* Add initial haves */
> > + ret = add_haves(_buf, in_vain);
>
> I like the shortness and conciseness of this send_fetch_request
> function as it makes clear what is happening over the wire, however
> I wonder if we can improve on that,
On Tue, Feb 6, 2018 at 5:12 PM, Brandon Williams wrote:
> When communicating with a v2 server, perform a fetch by requesting the
> 'fetch' command.
>
> Signed-off-by: Brandon Williams
> ---
> builtin/fetch-pack.c | 2 +-
> fetch-pack.c | 252
On 02/23, Jonathan Tan wrote:
> On Tue, 6 Feb 2018 17:12:58 -0800
> Brandon Williams wrote:
>
> > + while ((oid = get_rev())) {
> > + packet_buf_write(req_buf, "have %s\n", oid_to_hex(oid));
> > + if (++haves_added >= INITIAL_FLUSH)
> > +
On Tue, 6 Feb 2018 17:12:58 -0800
Brandon Williams wrote:
> + while ((oid = get_rev())) {
> + packet_buf_write(req_buf, "have %s\n", oid_to_hex(oid));
> + if (++haves_added >= INITIAL_FLUSH)
> + break;
> + };
Unnecessary
When communicating with a v2 server, perform a fetch by requesting the
'fetch' command.
Signed-off-by: Brandon Williams
---
builtin/fetch-pack.c | 2 +-
fetch-pack.c | 252 -
fetch-pack.h | 4 +-
5 matches
Mail list logo