Re: [PATCH v3 3/3] commit: fix exit code for --short/--porcelain

2018-07-19 Thread Samuel Lijin
Thanks for the review. On Tue, Jul 17, 2018 at 10:33 AM Junio C Hamano wrote: > > Samuel Lijin writes: > > > diff --git a/wt-status.c b/wt-status.c > > index 75d389944..4ba657978 100644 > > --- a/wt-status.c > > +++ b/wt-status.c > > @@ -718,6 +718,39 @@ static void

Re: [PATCH v3 3/3] commit: fix exit code for --short/--porcelain

2018-07-17 Thread Junio C Hamano
Samuel Lijin writes: > diff --git a/wt-status.c b/wt-status.c > index 75d389944..4ba657978 100644 > --- a/wt-status.c > +++ b/wt-status.c > @@ -718,6 +718,39 @@ static void wt_status_collect_untracked(struct wt_status > *s) > s->untracked_in_ms = (getnanotime() - t_begin) /

[PATCH v3 3/3] commit: fix exit code for --short/--porcelain

2018-07-15 Thread Samuel Lijin
In wt-status.c, the s->commitable bit is set only in the call tree of wt_longstatus_print(), which means that when there are changes to be committed or all merge conflicts have been resolved, --dry-run and --long return the correct exit code, but --short and --porcelain do not, even though they