Re: [PATCH v3 3/6] Make the require_clean_work_tree() function reusable

2016-10-05 Thread Junio C Hamano
Johannes Schindelin writes: >> The function "git pull" uses to stop the user when the working >> tree has changes is useful in other places. > > I stumbled over this sentence. How about > > The function used by "git pull" to stop [...] > > instead? Perfect. Thanks.

Re: [PATCH v3 3/6] Make the require_clean_work_tree() function reusable

2016-10-05 Thread Johannes Schindelin
Hi Junio, On Tue, 4 Oct 2016, Junio C Hamano wrote: > I'd tweak the message while queuing, though. > > wt-status: make the require_clean_work_tree() function reusable > > The function "git pull" uses to stop the user when the working > tree has changes is useful in other places.

Re: [PATCH v3 3/6] Make the require_clean_work_tree() function reusable

2016-10-04 Thread Junio C Hamano
Johannes Schindelin writes: > It is remarkable that libgit.a did not sport this function yet... Let's > move it into a more prominent (and into an actually reusable) spot: > wt-status.[ch]. > > Signed-off-by: Johannes Schindelin > --- Thanks. I'd tweak the message while queuing, though. w

[PATCH v3 3/6] Make the require_clean_work_tree() function reusable

2016-10-04 Thread Johannes Schindelin
It is remarkable that libgit.a did not sport this function yet... Let's move it into a more prominent (and into an actually reusable) spot: wt-status.[ch]. Signed-off-by: Johannes Schindelin --- builtin/pull.c | 77 +- wt-status.c| 76 +