Re: [PATCH v3 3/6] diff: allow --patch cie to override -s/--no-patch

2013-07-15 Thread Jonathan Nieder
Matthieu Moy wrote: All options that trigger a patch output now override --no-patch. The case of --binary is particular as the name may suggest that it turns Usage nit: this should say is unusual or In the case of --binary in particular, the name may suggest a normal patch into a

Re: [PATCH v3 3/6] diff: allow --patch cie to override -s/--no-patch

2013-07-15 Thread Matthieu Moy
Jonathan Nieder jrnie...@gmail.com writes: Matthieu Moy wrote: All options that trigger a patch output now override --no-patch. The case of --binary is particular as the name may suggest that it turns Usage nit: this should say is unusual I don't get it. The point is not that --binary is

Re: [PATCH v3 3/6] diff: allow --patch cie to override -s/--no-patch

2013-07-15 Thread Jonathan Nieder
Matthieu Moy wrote: Jonathan Nieder jrnie...@gmail.com writes: Matthieu Moy wrote: All options that trigger a patch output now override --no-patch. The case of --binary is particular as the name may suggest that it turns Usage nit: this should say is unusual I don't get it. The point is