Re: [PATCH v3 3/7] fetch-pack: directly end negotiation if ACK ready

2018-06-15 Thread Junio C Hamano
Jonathan Tan writes: > When "ACK %s ready" is received, find_common() clears rev_list in an > attempt to stop further "have" lines from being sent [1]. It is much > more readable to explicitly break from the loop instead. > > So explicitly break from the loop, and make the clearing of the

[PATCH v3 3/7] fetch-pack: directly end negotiation if ACK ready

2018-06-14 Thread Jonathan Tan
When "ACK %s ready" is received, find_common() clears rev_list in an attempt to stop further "have" lines from being sent [1]. It is much more readable to explicitly break from the loop instead. So explicitly break from the loop, and make the clearing of the rev_list happen unconditionally. [1]