Re: [PATCH v3 4/5] stash: introduce new format create

2017-02-14 Thread Thomas Gummerer
On 02/13, Jeff King wrote: > On Mon, Feb 13, 2017 at 04:57:34PM -0500, Jeff King wrote: > > > Yeah, I think your patch is actually fixing that case. But your search > > is only part of the story. You found somebody using "-m" explicitly, but > > what about somebody blindly calling: > > > > git

Re: [PATCH v3 4/5] stash: introduce new format create

2017-02-13 Thread Jeff King
On Mon, Feb 13, 2017 at 04:57:34PM -0500, Jeff King wrote: > Yeah, I think your patch is actually fixing that case. But your search > is only part of the story. You found somebody using "-m" explicitly, but > what about somebody blindly calling: > > git stash create $* > > That's now

Re: [PATCH v3 4/5] stash: introduce new format create

2017-02-13 Thread Jeff King
On Sat, Feb 11, 2017 at 02:51:27PM +, Thomas Gummerer wrote: > > How do we tell the difference between new-style invocations, and > > old-style ones that look new-style? IOW, I think: > > > > git stash create -m works > > > > currently treats "-m works" as the full message, and it would

Re: [PATCH v3 4/5] stash: introduce new format create

2017-02-11 Thread Thomas Gummerer
On 02/06, Jeff King wrote: > On Sun, Feb 05, 2017 at 08:26:41PM +, Thomas Gummerer wrote: > > > git stash create currently supports a positional argument for adding a > > message. This is not quite in line with how git commands usually take > > comments (using a -m flag). > > > > Add a new

Re: [PATCH v3 4/5] stash: introduce new format create

2017-02-06 Thread Jeff King
On Sun, Feb 05, 2017 at 08:26:41PM +, Thomas Gummerer wrote: > git stash create currently supports a positional argument for adding a > message. This is not quite in line with how git commands usually take > comments (using a -m flag). > > Add a new syntax for adding a message to git stash

[PATCH v3 4/5] stash: introduce new format create

2017-02-05 Thread Thomas Gummerer
git stash create currently supports a positional argument for adding a message. This is not quite in line with how git commands usually take comments (using a -m flag). Add a new syntax for adding a message to git stash create using a -m flag. This is with the goal of deprecating the old style