Re: [PATCH v3 4/6] git.c: implement --list-cmds=porcelain

On Wed, Apr 25, 2018 at 3:46 PM, SZEDER Gábor wrote: > On Tue, Apr 24, 2018 at 6:17 PM, Duy Nguyen wrote: >> On Tue, Apr 24, 2018 at 6:12 PM, Duy Nguyen wrote: >>> git-completion.bash will be updated to ask git "give me the commands

Re: [PATCH v3 4/6] git.c: implement --list-cmds=porcelain

On Wed, Apr 25, 2018 at 3:06 PM, SZEDER Gábor wrote: >> -__git_list_all_commands () > >> -__git_list_porcelain_commands () > > Users can have their own completion scriptlets for their own git > commands, and these should be able to rely on helper functions in >

Re: [PATCH v3 4/6] git.c: implement --list-cmds=porcelain

On Tue, Apr 24, 2018 at 6:17 PM, Duy Nguyen wrote: > On Tue, Apr 24, 2018 at 6:12 PM, Duy Nguyen wrote: >> git-completion.bash will be updated to ask git "give me the commands >> in the mainporcelain, completable or external category". This also >> addresses

Re: [PATCH v3 4/6] git.c: implement --list-cmds=porcelain

On Sat, Apr 21, 2018 at 6:54 PM, Nguyễn Thái Ngọc Duy wrote: > diff --git a/contrib/completion/git-completion.bash > b/contrib/completion/git-completion.bash > index a5f13ade20..7d17ca23f6 100644 > --- a/contrib/completion/git-completion.bash > +++

Re: [PATCH v3 4/6] git.c: implement --list-cmds=porcelain

On Tue, Apr 24, 2018 at 6:12 PM, Duy Nguyen wrote: > git-completion.bash will be updated to ask git "give me the commands > in the mainporcelain, completable or external category". This also > addresses another thing that bugs me: I wanted an option to let me > complete all

Re: [PATCH v3 4/6] git.c: implement --list-cmds=porcelain

On Mon, Apr 23, 2018 at 3:32 PM, SZEDER Gábor wrote: > But then I noticed that it's not an accurate description of the > current situation, because there is a wide grey area between > porcelains and plumbing, and the completion script doesn't "filter out > plumbing

Re: [PATCH v3 4/6] git.c: implement --list-cmds=porcelain

On Sat, Apr 21, 2018 at 6:54 PM, Nguyễn Thái Ngọc Duy wrote: > This is useful for git-completion.bash because it needs this set of > commands. Right now we have to maintain a separate command category in > there. I don't really understand this paragraph, in particular its

[PATCH v3 4/6] git.c: implement --list-cmds=porcelain

This is useful for git-completion.bash because it needs this set of commands. Right now we have to maintain a separate command category in there. Note that the current completion script incorrectly classifies filter-branch as porcelain and t9902 tests this behavior. We keep it this way in t9902