Re: [PATCH v3 4/9] rebase -i: also expand/collapse the SHA-1s via the rebase--helper

Hi Junio, On Thu, 27 Apr 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> > +out = fopen(todo_file, "w"); > >> > >> The usual "open lockfile, write to it and then rename" dance is not > >> necessary for the purpose of preventing other people

Re: [PATCH v3 4/9] rebase -i: also expand/collapse the SHA-1s via the rebase--helper

Johannes Schindelin writes: >> > + out = fopen(todo_file, "w"); >> >> The usual "open lockfile, write to it and then rename" dance is not >> necessary for the purpose of preventing other people from reading >> this file while we are writing to it. But if we fail

Re: [PATCH v3 4/9] rebase -i: also expand/collapse the SHA-1s via the rebase--helper

Hi Junio, On Wed, 26 Apr 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh > > index 214af0372ba..52a19e0bdb3 100644 > > --- a/git-rebase--interactive.sh > > +++

Re: [PATCH v3 4/9] rebase -i: also expand/collapse the SHA-1s via the rebase--helper

Junio C Hamano writes: > Johannes Schindelin writes: > >> diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh >> index 214af0372ba..52a19e0bdb3 100644 >> --- a/git-rebase--interactive.sh >> +++ b/git-rebase--interactive.sh >> @@

Re: [PATCH v3 4/9] rebase -i: also expand/collapse the SHA-1s via the rebase--helper

Johannes Schindelin writes: > diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh > index 214af0372ba..52a19e0bdb3 100644 > --- a/git-rebase--interactive.sh > +++ b/git-rebase--interactive.sh > @@ -774,11 +774,11 @@ transform_todo_ids () { > } > >

[PATCH v3 4/9] rebase -i: also expand/collapse the SHA-1s via the rebase--helper

This is crucial to improve performance on Windows, as the speed is now mostly dominated by the SHA-1 transformation (because it spawns a new rev-parse process for *every* line, and spawning processes is pretty slow from Git for Windows' MSYS2 Bash). Signed-off-by: Johannes Schindelin