Re: [PATCH v3 48/49] builtin/apply: move 'lock_file' global into 'struct apply_state'

On Wed, Jun 1, 2016 at 7:23 PM, Junio C Hamano wrote: > Christian Couder writes: > >> We cannot have a 'struct lock_file' allocated on the stack, as lockfile.c >> keeps a linked list of all created lock_file structures. So let's make the >>

Re: [PATCH v3 48/49] builtin/apply: move 'lock_file' global into 'struct apply_state'

Christian Couder writes: > We cannot have a 'struct lock_file' allocated on the stack, as lockfile.c > keeps a linked list of all created lock_file structures. So let's make the > 'lock_file' variable a pointer to a 'struct lock_file' Good. > As the same instance of

[PATCH v3 48/49] builtin/apply: move 'lock_file' global into 'struct apply_state'

We cannot have a 'struct lock_file' allocated on the stack, as lockfile.c keeps a linked list of all created lock_file structures. So let's make the 'lock_file' variable a pointer to a 'struct lock_file' As the same instance of this struct can be reused, let's add an argument to