Re: [PATCH v3 5/6] grep: enable recurse-submodules to work on objects

2016-11-17 Thread Brandon Williams
On 11/15, Stefan Beller wrote: > On Fri, Nov 11, 2016 at 3:51 PM, Brandon Williams wrote: > > + /* > > +* Add basename of parent project > > +* When performing grep on a object the filename is prefixed > > +* with the object's name: ':filename'. >

Re: [PATCH v3 5/6] grep: enable recurse-submodules to work on objects

2016-11-15 Thread Stefan Beller
On Fri, Nov 11, 2016 at 3:51 PM, Brandon Williams wrote: > to: > HEAD:file > HEAD:sub/file Maybe indent this ;) > static struct argv_array submodule_options = ARGV_ARRAY_INIT; > +static const char *parent_basename; > > static int grep_submodule_launch(struct grep_opt

Re: [PATCH v3 5/6] grep: enable recurse-submodules to work on objects

2016-11-14 Thread Brandon Williams
On 11/14, Jonathan Tan wrote: > On 11/14/2016 10:56 AM, Junio C Hamano wrote: > >Jonathan Tan writes: > > > to: > HEAD:file > HEAD:sub/file > > Signed-off-by: Brandon Williams > --- > >>> > >>>Unrelated tangent, but this makes

Re: [PATCH v3 5/6] grep: enable recurse-submodules to work on objects

2016-11-14 Thread Jonathan Tan
On 11/14/2016 10:56 AM, Junio C Hamano wrote: Jonathan Tan writes: to: HEAD:file HEAD:sub/file Signed-off-by: Brandon Williams --- Unrelated tangent, but this makes readers wonder what the updated trailer code would do to the last paragraph

Re: [PATCH v3 5/6] grep: enable recurse-submodules to work on objects

2016-11-14 Thread Junio C Hamano
Jonathan Tan writes: >>> to: >>> HEAD:file >>> HEAD:sub/file >>> >>> Signed-off-by: Brandon Williams >>> --- >> >> Unrelated tangent, but this makes readers wonder what the updated >> trailer code would do to the last paragraph ;-). Does it behave

Re: [PATCH v3 5/6] grep: enable recurse-submodules to work on objects

2016-11-14 Thread Jonathan Tan
On 11/14/2016 10:10 AM, Junio C Hamano wrote: Brandon Williams writes: Teach grep to recursively search in submodules when provided with a object. This allows grep to search a submodule based on the state of the submodule that is present in a commit of the super project.

Re: [PATCH v3 5/6] grep: enable recurse-submodules to work on objects

2016-11-14 Thread Junio C Hamano
Brandon Williams writes: > Teach grep to recursively search in submodules when provided with a > object. This allows grep to search a submodule based on the state > of the submodule that is present in a commit of the super project. > > When grep is provided with a object,

[PATCH v3 5/6] grep: enable recurse-submodules to work on objects

2016-11-11 Thread Brandon Williams
Teach grep to recursively search in submodules when provided with a object. This allows grep to search a submodule based on the state of the submodule that is present in a commit of the super project. When grep is provided with a object, the name of the object is prefixed to all output. In