Re: [PATCH v3 5/6] split-index: don't compare stat data of entries already marked for split index

2018-09-29 Thread SZEDER Gábor
On Sat, Sep 29, 2018 at 11:14:29AM +0200, SZEDER Gábor wrote: > > > Note that comparing the cached data in copied and original entries in > > > > s/cached data/cached stat data/ ? I was confused for a bit. > > No, it's indeed cached data, but now that you mention it, the subject > line does need

Re: [PATCH v3 5/6] split-index: don't compare stat data of entries already marked for split index

2018-09-29 Thread SZEDER Gábor
On Sat, Sep 29, 2018 at 07:36:08AM +0200, Duy Nguyen wrote: > On Fri, Sep 28, 2018 at 06:24:58PM +0200, SZEDER Gábor wrote: > > When unpack_trees() constructs a new index, it copies cache entries > > from the original index [1]. prepare_to_write_split_index() has to > > deal with this, and it has

Re: [PATCH v3 5/6] split-index: don't compare stat data of entries already marked for split index

2018-09-28 Thread Duy Nguyen
On Fri, Sep 28, 2018 at 06:24:58PM +0200, SZEDER Gábor wrote: > When unpack_trees() constructs a new index, it copies cache entries > from the original index [1]. prepare_to_write_split_index() has to > deal with this, and it has a dedicated code path for copied entries > that are present in the

[PATCH v3 5/6] split-index: don't compare stat data of entries already marked for split index

2018-09-28 Thread SZEDER Gábor
When unpack_trees() constructs a new index, it copies cache entries from the original index [1]. prepare_to_write_split_index() has to deal with this, and it has a dedicated code path for copied entries that are present in the shared index, where it compares the cached data in the corresponding