Re: [PATCH v3 5/9] ref-filter: use generation number for --contains

2018-04-25 Thread Derrick Stolee
On 4/24/2018 2:56 PM, Jakub Narebski wrote: Derrick Stolee writes: One way to fix this is to call 'prepare_commit_graph()' directly and then test that 'commit_graph' is non-null before performing any parses. I'm not thrilled with how that couples the commit-graph

Re: [PATCH v3 5/9] ref-filter: use generation number for --contains

2018-04-24 Thread Jakub Narebski
Derrick Stolee writes: > On 4/18/2018 5:02 PM, Jakub Narebski wrote: >> Derrick Stolee writes: >> >>> A commit A can reach a commit B only if the generation number of A >>> is larger than the generation number of B. This condition allows >>> significantly

Re: [PATCH v3 5/9] ref-filter: use generation number for --contains

2018-04-23 Thread Derrick Stolee
On 4/18/2018 5:02 PM, Jakub Narebski wrote: Here I can offer only the cursory examination, as I don't know this area of code in question. Derrick Stolee writes: A commit A can reach a commit B only if the generation number of A is larger than the generation number of

Re: [PATCH v3 5/9] ref-filter: use generation number for --contains

2018-04-18 Thread Jakub Narebski
Here I can offer only the cursory examination, as I don't know this area of code in question. Derrick Stolee writes: > A commit A can reach a commit B only if the generation number of A > is larger than the generation number of B. This condition allows > significantly

[PATCH v3 5/9] ref-filter: use generation number for --contains

2018-04-17 Thread Derrick Stolee
A commit A can reach a commit B only if the generation number of A is larger than the generation number of B. This condition allows significantly short-circuiting commit-graph walks. Use generation number for 'git tag --contains' queries. On a copy of the Linux repository where HEAD is containd