Re: [PATCH v3 6/6] notes-util.c: replace `git_config()` with `git_config_get_value()`

On Mon, Jul 21, 2014 at 04:12:25AM -0700, Tanay Abhra wrote: -static int notes_rewrite_config(const char *k, const char *v, void *cb) +static void notes_rewrite_config(struct notes_rewrite_cfg *c) { - struct notes_rewrite_cfg *c = cb; - if (starts_with(k, notes.rewrite.)

[PATCH v3 6/6] notes-util.c: replace `git_config()` with `git_config_get_value()`

Use `git_config_get_value()` instead of `git_config()` to take advantage of the config-set API which provides a cleaner control flow. The function now raises an error instead of dying when a NULL value is found for key notes.rewritemode. Signed-off-by: Tanay Abhra tanay...@gmail.com ---