Re: [PATCH v3 6/9] multi-pack-index: implement 'expire' verb

2019-01-24 Thread Derrick Stolee
On 1/23/2019 5:13 PM, Jonathan Tan wrote: Maybe add a fsck at the end for sanity's sake. Also, I think that preservation of .keep packfiles is an important feature, and maybe worth a test. Good points! I forgot to test the .keep stuff directly here because I have an equivalent test in VFS for Gi

Re: [PATCH v3 6/9] multi-pack-index: implement 'expire' verb

2019-01-23 Thread Jonathan Tan
> From: Derrick Stolee > > The 'git multi-pack-index expire' command looks at the existing > mult-pack-index, counts the number of objects referenced in each > pack-file, deletes the pack-fils with no referenced objects, and > rewrites the multi-pack-index to no longer reference those packs. Tha

Re: [PATCH v3 6/9] multi-pack-index: implement 'expire' verb

2019-01-10 Thread Junio C Hamano
SZEDER Gábor writes: > On Wed, Jan 09, 2019 at 07:21:16AM -0800, Derrick Stolee via GitGitGadget > wrote: >> The 'git multi-pack-index expire' command ... > > The subject line could use a s/verb/subcommand/. Yeah, that probably is more in line with the existing terminology for other Git command

Re: [PATCH v3 6/9] multi-pack-index: implement 'expire' verb

2019-01-09 Thread SZEDER Gábor
On Wed, Jan 09, 2019 at 07:21:16AM -0800, Derrick Stolee via GitGitGadget wrote: > The 'git multi-pack-index expire' command ... The subject line could use a s/verb/subcommand/.

[PATCH v3 6/9] multi-pack-index: implement 'expire' verb

2019-01-09 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The 'git multi-pack-index expire' command looks at the existing mult-pack-index, counts the number of objects referenced in each pack-file, deletes the pack-fils with no referenced objects, and rewrites the multi-pack-index to no longer reference those packs. Refactor the wr