Re: [PATCH v3 6/9] rebase -i: check for missing commits in the rebase--helper

Hi Junio, On Wed, 26 Apr 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > -check_todo_list > > +git rebase--helper --check-todo-list || { > > + ret=$? > > + checkout_onto > > + exit $ret > > +} > > I find this a better division of labor

Re: [PATCH v3 6/9] rebase -i: check for missing commits in the rebase--helper

Johannes Schindelin writes: > -check_todo_list > +git rebase--helper --check-todo-list || { > + ret=$? > + checkout_onto > + exit $ret > +} I find this a better division of labor between "check_todo_list" and its caller. Compared to the original that did

[PATCH v3 6/9] rebase -i: check for missing commits in the rebase--helper

In particular on Windows, where shell scripts are even more expensive than on MacOSX or Linux, it makes sense to move a loop that forks Git at least once for every line in the todo list into a builtin. Signed-off-by: Johannes Schindelin --- builtin/rebase--helper.c