Re: [PATCH v4] git-clean: Display more accurate delete messages

2013-01-10 Thread Zoltan Klinger
I think the code before this patch used to say Would not remove and Not removing in certain cases to report the paths that the command decided not to remove, but after this patch these two messages no longer appear in the patch. Is it expected, are we losing information, or...? I do not

Re: [PATCH v4] git-clean: Display more accurate delete messages

2013-01-10 Thread Junio C Hamano
Zoltan Klinger zoltan.klin...@gmail.com writes: I think the code before this patch used to say Would not remove and Not removing in certain cases to report the paths that the command decided not to remove, but after this patch these two messages no longer appear in the patch. Is it

Re: [PATCH v4] git-clean: Display more accurate delete messages

2013-01-09 Thread Zoltan Klinger
I wonder whether it's possible to make the output more consistent, as in: Removing tracked_dir/some_untracked_file Removing untracked_file Skipping repository untracked_foo/frotz.git Removing untracked_foo/bar Removing untracked_foo/emptydir Skipping repository

Re: [PATCH v4] git-clean: Display more accurate delete messages

2013-01-09 Thread Junio C Hamano
Zoltan Klinger zoltan.klin...@gmail.com writes: Consider the output of the improved version: $ git clean -fd Removing tracked_dir/some_untracked_file Removing untracked_file warning: ignoring untracked git repository untracked_foo/frotz.git Removing untracked_foo/bar Removing

[PATCH v4] git-clean: Display more accurate delete messages

2013-01-06 Thread Zoltan Klinger
(1) Only print out the names of the files and directories that got actually deleted. (2) Show warning message for ignored untracked git repositories Consider the following repo layout: test.git/ |-- tracked_dir/ | |-- some_tracked_file | |-- some_untracked_file |--

Re: [PATCH v4] git-clean: Display more accurate delete messages

2013-01-06 Thread Jonathan Nieder
Zoltan Klinger wrote: $ git clean -fd Removing tracked_dir/some_untracked_file Removing untracked_file Removing untracked_foo/ Removing untracked_some.git/ The message displayed to the user is slightly misleading. The foo/ directory has not been removed because of foo/frotz.git