Re: [PATCH v4] git-gui: Prevent double UTF-8 conversion

2017-12-14 Thread Eric Sunshine
On Thu, Dec 14, 2017 at 5:43 AM, Łukasz Stelmach wrote: > It was <2017-12-14 czw 10:42>, when Eric Sunshine wrote: >> No need to re-send. If you consult Junio's latest "What's cooking"[1], >> you'll find that your patch has already graduated from his 'pu' branch >> to

Re: [PATCH v4] git-gui: Prevent double UTF-8 conversion

2017-12-14 Thread Łukasz Stelmach
It was <2017-12-14 czw 10:42>, when Eric Sunshine wrote: > On Thu, Dec 14, 2017 at 4:32 AM, Łukasz Stelmach > wrote: >> Convert author's name and e-mail address from the UTF-8 (or any other) >> encoding in load_last_commit function the same way commit message is >>

Re: [PATCH v4] git-gui: Prevent double UTF-8 conversion

2017-12-14 Thread Eric Sunshine
On Thu, Dec 14, 2017 at 4:32 AM, Łukasz Stelmach wrote: > Convert author's name and e-mail address from the UTF-8 (or any other) > encoding in load_last_commit function the same way commit message is > converted. > > Amending commits in git-gui without such conversion

[PATCH v4] git-gui: Prevent double UTF-8 conversion

2017-12-14 Thread Łukasz Stelmach
Convert author's name and e-mail address from the UTF-8 (or any other) encoding in load_last_commit function the same way commit message is converted. Amending commits in git-gui without such conversion breaks UTF-8 strings. For example, "\305\201ukasz" (as written by git cat-file) becomes