Re: [PATCH v4] json_writer: new routines to create data in JSON format

On 6/2/2018 1:13 AM, Jeff King wrote: On Sat, Jun 02, 2018 at 06:41:06AM +0200, Duy Nguyen wrote: On Mon, Mar 26, 2018 at 4:31 PM, wrote: +static inline void assert_in_array(const struct json_writer *jw) +{ + if (!jw->open_stack.len) + die("json-writer: array: missing

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On Sat, Jun 02, 2018 at 06:41:06AM +0200, Duy Nguyen wrote: > On Mon, Mar 26, 2018 at 4:31 PM, wrote: > > +static inline void assert_in_array(const struct json_writer *jw) > > +{ > > + if (!jw->open_stack.len) > > + die("json-writer: array: missing jw_array_begin()"); > >

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On Mon, Mar 26, 2018 at 4:31 PM, wrote: > +static inline void assert_in_array(const struct json_writer *jw) > +{ > + if (!jw->open_stack.len) > + die("json-writer: array: missing jw_array_begin()"); When you reroll, please consider marking all these string for translation

Re: [PATCH v4] json_writer: new routines to create data in JSON format

Ramsay Jones writes: > BTW, I forgot to mention that you had some whitespace problems > with this patch, viz: > > $ git log --oneline -1 --check master-json > ab643d838 (master-json) json_writer: new routines to create data in JSON > format >

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On 27/03/18 18:14, Jeff Hostetler wrote: > > > On 3/27/2018 11:45 AM, Ramsay Jones wrote: >> >> >> On 27/03/18 04:18, Ramsay Jones wrote: >>> On 26/03/18 15:31, g...@jeffhostetler.com wrote: From: Jeff Hostetler >>> [snip] >>> >>> Thanks, this version fixes

RE: [PATCH v4] json_writer: new routines to create data in JSON format

On March 27, 2018 1:43 PM, Wink Saville wrote: > > the leading spaces are required in this case. > > the pretty json output contains 8 spaces for that sub-structure not a tab. > > is there a preferred way to denote this in the test script? > > > > Jeff > > I've used "git diff --check" which I got

Re: [PATCH v4] json_writer: new routines to create data in JSON format

> the leading spaces are required in this case. > the pretty json output contains 8 spaces for that sub-structure not a tab. > is there a preferred way to denote this in the test script? > > Jeff I've used "git diff --check" which I got from Documentation/SubmittingPatches. -- Wink

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On 3/27/2018 11:45 AM, Ramsay Jones wrote: On 27/03/18 04:18, Ramsay Jones wrote: On 26/03/18 15:31, g...@jeffhostetler.com wrote: From: Jeff Hostetler [snip] Thanks, this version fixes all issues I had (with the compilation and sparse warnings). [Was using

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On 27/03/18 04:18, Ramsay Jones wrote: > On 26/03/18 15:31, g...@jeffhostetler.com wrote: >> From: Jeff Hostetler >> > [snip] > > Thanks, this version fixes all issues I had (with the compilation > and sparse warnings). > > [Was using UINT64_C(0x) a

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On 3/26/2018 11:18 PM, Ramsay Jones wrote: On 26/03/18 15:31, g...@jeffhostetler.com wrote: From: Jeff Hostetler [snip] Thanks, this version fixes all issues I had (with the compilation and sparse warnings). [Was using UINT64_C(0x) a problem on

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On 26/03/18 15:31, g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > Add a series of jw_ routines and "struct json_writer" structure to compose > JSON data. The resulting string data can then be output by commands wanting > to support a JSON output format. > >

[PATCH v4] json_writer: new routines to create data in JSON format

From: Jeff Hostetler Add a series of jw_ routines and "struct json_writer" structure to compose JSON data. The resulting string data can then be output by commands wanting to support a JSON output format. The json-writer routines can be used to generate structured data