Jeff King p...@peff.net writes:
# and have 472 and 59 different commits each, respectively.
#
# Untracked files:
[...]
and have 472 and 59 different commits each, respectively.
Untracked files:
Indeed, I forgot the else branch in wt_status_print_tracking:
if
Jeff King wrote:
On Thu, Sep 05, 2013 at 09:36:47PM +0200, Matthieu Moy wrote:
I'm fine with any name actually (since it is enabled by default, people
don't need to know the name to benefit from the new output). Maybe
status.displayCommentPrefix was the best name after all.
FWIW, I had the
Jonathan Nieder jrnie...@gmail.com writes:
Jeff King wrote:
On Thu, Sep 05, 2013 at 09:36:47PM +0200, Matthieu Moy wrote:
I'm fine with any name actually (since it is enabled by default, people
don't need to know the name to benefit from the new output). Maybe
status.displayCommentPrefix
Matthieu Moy matthieu@grenoble-inp.fr writes:
Untracked files:
t/foo
test-obj-pool
test-string-pool
test-treap
test-url-normalize
nothing added to commit but untracked files present
The added blank line before nothing added
Junio C Hamano gits...@pobox.com writes:
Actually, nothing added ... is not a part of status proper; it
will be clear if you run the command with comment prefix, whose
output may end like so:
# Untracked files:
# (use git add file... to include in what will be committed)
#
On Fri, Sep 06, 2013 at 07:28:43PM +0200, Matthieu Moy wrote:
FWIW, I had the same thought as Junio. I much prefer something like
status.displayCommentPrefix for clarity and future-proofing.
Sounds fine, but I don't understand why we'd want this to be an option
with a future in the
Compared to v2, this changes essentially:
* The prefix is actually disabled by default in this version. As a
consequence, the option is renamed to status.oldStyle.
* Since this is the default, the tests are updated to test the new
defaults. In a first patch, I'm setting status.oldStyle=true
Oops, this series forgot to update t7512-status-help.sh, which now
fails.
I'll send a reroll that updates it later (patch below).
diff --git a/t/t7512-status-help.sh b/t/t7512-status-help.sh
index 31a798f..0688d58 100755
--- a/t/t7512-status-help.sh
+++ b/t/t7512-status-help.sh
@@ -25,18 +25,18
Matthieu Moy matthieu@imag.fr writes:
Compared to v2, this changes essentially:
* The prefix is actually disabled by default in this version. As a
consequence, the option is renamed to status.oldStyle.
* Since this is the default, the tests are updated to test the new
defaults. In
Junio C Hamano gits...@pobox.com writes:
One caveat, though. The name oldStyle will become problematic,
when we want to remove some wart in the output format long after
this no comment prefix by default series lands. Some people may
expect setting oldStyle=true would give output from 1.8.4
Matthieu Moy matthieu@grenoble-inp.fr writes:
Junio C Hamano gits...@pobox.com writes:
One caveat, though. The name oldStyle will become problematic,
when we want to remove some wart in the output format long after
this no comment prefix by default series lands. Some people may
expect
On Thu, Sep 05, 2013 at 09:36:47PM +0200, Matthieu Moy wrote:
Junio C Hamano gits...@pobox.com writes:
One caveat, though. The name oldStyle will become problematic,
when we want to remove some wart in the output format long after
this no comment prefix by default series lands. Some
12 matches
Mail list logo
