Re: [PATCH v4 0/5] am/rebase: share read_author_script()

2018-11-01 Thread Phillip Wood
Hi Junio On 01/11/2018 03:01, Junio C Hamano wrote: Phillip Wood writes: From: Phillip Wood Sorry for the confusion with v3, here are the updated patches. Thanks to Junio for the feedback on v2. I've updated patch 4 based on those comments, the rest are unchanged. The mistake of

Re: [PATCH v4 0/5] am/rebase: share read_author_script()

2018-10-31 Thread Junio C Hamano
Phillip Wood writes: > From: Phillip Wood > > Sorry for the confusion with v3, here are the updated patches. > > Thanks to Junio for the feedback on v2. I've updated patch 4 based on > those comments, the rest are unchanged. The mistake of overwriting -1 (i.e. earlier we detected dup) with the

[PATCH v4 0/5] am/rebase: share read_author_script()

2018-10-31 Thread Phillip Wood
From: Phillip Wood Sorry for the confusion with v3, here are the updated patches. Thanks to Junio for the feedback on v2. I've updated patch 4 based on those comments, the rest are unchanged. v1 cover letter: This is a follow up to pw/rebase-i-author-script-fix, it reduces code duplication