Re: [PATCH v4 0/7] replacing strbuf_getline_lf() by strbuf_getline()

2016-03-09 Thread Junio C Hamano
Moritz Neeb writes: > What I can imagine could lead towards finding regessions, though > maybe a bit aimless: Go through the list of changes/patches that > are supposed to be included in v2.8.0 and confirm they are working > as expected. This would be like a post-review.

Re: [PATCH v4 0/7] replacing strbuf_getline_lf() by strbuf_getline()

2016-03-08 Thread Eric Sunshine
On Tue, Mar 8, 2016 at 7:25 PM, Moritz Neeb wrote: > how to deal with patches during the v2.8.0 rc freeze? Will they wait on > the mailing list until the feature release cycle is finished? > > Or if it's me who should act on this series, because it got below the > radar

Re: [PATCH v4 0/7] replacing strbuf_getline_lf() by strbuf_getline()

2016-03-08 Thread Moritz Neeb
On 03/09/2016 01:39 AM, Junio C Hamano wrote: > Moritz Neeb writes: > >> how to deal with patches during the v2.8.0 rc freeze? Will they wait on >> the mailing list until the feature release cycle is finished? > > Because people are expected to stop getting distracted by

Re: [PATCH v4 0/7] replacing strbuf_getline_lf() by strbuf_getline()

2016-03-08 Thread Junio C Hamano
Moritz Neeb writes: > how to deal with patches during the v2.8.0 rc freeze? Will they wait on > the mailing list until the feature release cycle is finished? Because people are expected to stop getting distracted by new features and no-op clean-up changes and instead to

Re: [PATCH v4 0/7] replacing strbuf_getline_lf() by strbuf_getline()

2016-03-08 Thread Moritz Neeb
Hi, how to deal with patches during the v2.8.0 rc freeze? Will they wait on the mailing list until the feature release cycle is finished? Or if it's me who should act on this series, because it got below the radar during the rc freeze? To my knowledge there's only minor points that have to be

Re: [PATCH v4 0/7] replacing strbuf_getline_lf() by strbuf_getline()

2016-02-29 Thread Eric Sunshine
On Mon, Feb 29, 2016 at 3:30 AM, Moritz Neeb wrote: > Although I was not sure [4], I decided to roll out v4, in the hope that the > next > reviewers will profit by the more polished commit messages and order. > > Changes since v3 [3] (the changes to single patches are

[PATCH v4 0/7] replacing strbuf_getline_lf() by strbuf_getline()

2016-02-29 Thread Moritz Neeb
Although I was not sure [4], I decided to roll out v4, in the hope that the next reviewers will profit by the more polished commit messages and order. This series deals with strbuf_getline_lf() in certain codepaths: Those, where the input that is read, is/was trimmed before doing anything that