Re: [PATCH v4 03/10] commit-graph: compute generation numbers

Derrick Stolee writes: > On 4/29/2018 5:08 AM, Jakub Narebski wrote: >> Derrick Stolee writes: [...] >> It is a bit strange to me that the code uses get_be32 for reading, but >> htonl for writing. Is Git tested on non little-endian machines, like >>

Re: [PATCH v4 03/10] commit-graph: compute generation numbers

On 4/29/2018 5:08 AM, Jakub Narebski wrote: Derrick Stolee writes: While preparing commits to be written into a commit-graph file, compute the generation numbers using a depth-first strategy. Sidenote: for generation numbers it does not matter if we use depth-first or

Re: [PATCH v4 03/10] commit-graph: compute generation numbers

Derrick Stolee writes: > While preparing commits to be written into a commit-graph file, compute > the generation numbers using a depth-first strategy. Sidenote: for generation numbers it does not matter if we use depth-first or breadth-first strategy, but it is more

Re: [PATCH v4 03/10] commit-graph: compute generation numbers

On 4/26/2018 8:58 AM, Derrick Stolee wrote: n 4/25/2018 10:35 PM, Junio C Hamano wrote: Derrick Stolee writes: @@ -439,6 +439,9 @@ static void write_graph_chunk_data(struct hashfile *f, int hash_len,   else   packedDate[0] = 0;   +    if

Re: [PATCH v4 03/10] commit-graph: compute generation numbers

n 4/25/2018 10:35 PM, Junio C Hamano wrote: Derrick Stolee writes: @@ -439,6 +439,9 @@ static void write_graph_chunk_data(struct hashfile *f, int hash_len, else packedDate[0] = 0; + if ((*list)->generation !=

Re: [PATCH v4 03/10] commit-graph: compute generation numbers

Derrick Stolee writes: > @@ -439,6 +439,9 @@ static void write_graph_chunk_data(struct hashfile *f, > int hash_len, > else > packedDate[0] = 0; > > + if ((*list)->generation != GENERATION_NUMBER_INFINITY) > +

[PATCH v4 03/10] commit-graph: compute generation numbers

While preparing commits to be written into a commit-graph file, compute the generation numbers using a depth-first strategy. The only commits that are walked in this depth-first search are those without a precomputed generation number. Thus, computation time will be relative to the number of new