Re: [PATCH v4 05/10] commit-graph: always load commit-graph information

On 4/29/2018 6:14 PM, Jakub Narebski wrote: Derrick Stolee writes: Most code paths load commits using lookup_commit() and then parse_commit(). And this automatically loads commit graph if needed, thanks to changes in parse_commit_gently(), which parse_commit() uses.

Re: [PATCH v4 05/10] commit-graph: always load commit-graph information

[Forgot about one thing] Derrick Stolee writes: > Create new load_commit_graph_info() method to fill in the information > for a commit that exists only in the commit-graph file. The above sentence is a bit hard to parse because of ambiguity: is it "the information" that

Re: [PATCH v4 05/10] commit-graph: always load commit-graph information

Derrick Stolee writes: > Most code paths load commits using lookup_commit() and then > parse_commit(). And this automatically loads commit graph if needed, thanks to changes in parse_commit_gently(), which parse_commit() uses. > In some cases, including

[PATCH v4 05/10] commit-graph: always load commit-graph information

Most code paths load commits using lookup_commit() and then parse_commit(). In some cases, including some branch lookups, the commit is parsed using parse_object_buffer() which side-steps parse_commit() in favor of parse_commit_buffer(). With generation numbers in the commit-graph, we need to