When 'cherry-pick -s' is used to append a signed-off-by line to a cherry
picked commit, it does not currently detect the (cherry picked from...
that may have been appended by a previous 'cherry-pick -x' as part of the
s-o-b footer and it will insert a blank line before appending a new s-o-b.
Brandon Casey draf...@gmail.com writes:
When 'cherry-pick -s' is used to append a signed-off-by line to a cherry
picked commit, it does not currently detect the (cherry picked from...
that may have been appended by a previous 'cherry-pick -x' as part of the
s-o-b footer and it will insert a
On 2/12/2013 11:13 AM, Junio C Hamano wrote:
Brandon Casey draf...@gmail.com writes:
When 'cherry-pick -s' is used to append a signed-off-by line to a cherry
picked commit, it does not currently detect the (cherry picked from...
that may have been appended by a previous 'cherry-pick -x' as
Brandon Casey bca...@nvidia.com writes:
+ return len strlen(cherry_picked_prefix) + 1
+ !prefixcmp(buf, cherry_picked_prefix) buf[len - 1] == ')';
+}
Does the first is it longer than the prefix? check matter? If it
is not, prefixcmp() would not match anyway, no?
Probably
Brandon Casey wrote:
On 2/12/2013 11:13 AM, Junio C Hamano wrote:
Brandon Casey draf...@gmail.com writes:
+static int is_cherry_picked_from_line(const char *buf, int len)
+{
+ /*
+* We only care that it looks roughly like (cherry picked from ...)
+*/
+ return len
On 2/12/2013 11:36 AM, Junio C Hamano wrote:
Brandon Casey bca...@nvidia.com writes:
+ return len strlen(cherry_picked_prefix) + 1
+ !prefixcmp(buf, cherry_picked_prefix) buf[len - 1] == ')';
+}
Does the first is it longer than the prefix? check matter? If it
is not,
Brandon Casey bca...@nvidia.com writes:
On 2/12/2013 11:36 AM, Junio C Hamano wrote:
Brandon Casey bca...@nvidia.com writes:
+ return len strlen(cherry_picked_prefix) + 1
+ !prefixcmp(buf, cherry_picked_prefix) buf[len - 1] == ')';
+}
Does the first is it longer than the
7 matches
Mail list logo
