Re: [PATCH v4 08/10] dir: simplify untracked cache "ident" field

On Wed, Dec 30, 2015 at 12:47 PM, Torsten Bögershausen wrote: > On 2015-12-29 08.09, Christian Couder wrote: >> It is not a good idea to compare kernel versions and disable >> the untracked cache if it changes as people may upgrade and >> still want the untracked cache to work. So

Re: [PATCH v4 08/10] dir: simplify untracked cache "ident" field

On Tue, Dec 29, 2015 at 11:32 PM, Junio C Hamano wrote: > Christian Couder writes: > >> -static int ident_in_untracked(const struct untracked_cache *uc) >> +static int ident_current_location_in_untracked(const struct untracked_cache >> *uc) >> {

Re: [PATCH v4 08/10] dir: simplify untracked cache "ident" field

On 2015-12-29 08.09, Christian Couder wrote: > It is not a good idea to compare kernel versions and disable > the untracked cache if it changes as people may upgrade and > still want the untracked cache to work. So let's just > compare work tree locations to decide if we should disable > it. OK

Re: [PATCH v4 08/10] dir: simplify untracked cache "ident" field

Christian Couder writes: > -static int ident_in_untracked(const struct untracked_cache *uc) > +static int ident_current_location_in_untracked(const struct untracked_cache > *uc) > { > - const char *end = uc->ident.buf + uc->ident.len; > - const char *p =

[PATCH v4 08/10] dir: simplify untracked cache "ident" field

It is not a good idea to compare kernel versions and disable the untracked cache if it changes as people may upgrade and still want the untracked cache to work. So let's just compare work tree locations to decide if we should disable it. Also it's not useful to store many locations in the ident