Re: [PATCH v4 09/11] connect: use "-l user" instead of "user@" on ssh command line

On Tue, May 03, 2016 at 01:33:24PM -0400, Eric Sunshine wrote: > On Tue, May 3, 2016 at 4:50 AM, Mike Hommey wrote: > > While it is not strictly necessary, it makes the connect code simpler > > when there is user. > > > > Signed-off-by: Mike Hommey > > --- >

Re: [PATCH v4 09/11] connect: use "-l user" instead of "user@" on ssh command line

Torsten Bögershausen writes: > On 2016-05-03 10.50, Mike Hommey wrote: >> While it is not strictly necessary, it makes the connect code simpler >> when there is user. >> > > That commit message does't tell too much, I think. "Doesn't tell too much" is not necessarily bad, but

Re: [PATCH v4 09/11] connect: use "-l user" instead of "user@" on ssh command line

On Tue, May 3, 2016 at 4:50 AM, Mike Hommey wrote: > While it is not strictly necessary, it makes the connect code simpler > when there is user. > > Signed-off-by: Mike Hommey > --- > diff --git a/connect.c b/connect.c > @@ -812,14 +812,10 @@ struct

Re: [PATCH v4 09/11] connect: use "-l user" instead of "user@" on ssh command line

On 2016-05-03 10.50, Mike Hommey wrote: > While it is not strictly necessary, it makes the connect code simpler > when there is user. > That commit message does't tell too much, I think. Besides that, I'm sure it will break (at least) my ssh wrapper scripts, which rely on user@host to be passed

[PATCH v4 09/11] connect: use "-l user" instead of "user@" on ssh command line

While it is not strictly necessary, it makes the connect code simpler when there is user. Signed-off-by: Mike Hommey --- connect.c| 12 t/t5601-clone.sh | 52 2 files changed, 48 insertions(+), 16