[PATCH v4 1/2] diff-no-index.c: rename read_directory()

2014-03-19 Thread Andrei Dinu
Signed-off-by: Andrei Dinu mandrei.d...@gmail.com --- I plan on applying to GSoc 2014 diff-no-index.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/diff-no-index.c b/diff-no-index.c index 8e10bff..5e4a76c 100644 --- a/diff-no-index.c +++ b/diff-no-index.c @@

Re: [PATCH v4 1/2] diff-no-index.c: rename read_directory()

2014-03-19 Thread Matthieu Moy
Andrei Dinu mandrei.d...@gmail.com writes: Signed-off-by: Andrei Dinu mandrei.d...@gmail.com The commit message should explain why this is a good change. In general, the why? question is more important than the what (the reader can see from the patch that you renamed the function, but cannot