Re: [PATCH v4 1/2] refactor "dumb" terminal determination

2017-11-30 Thread Kaartic Sivaraam
On Wednesday 29 November 2017 08:07 PM, lars.schnei...@autodesk.com wrote: +int is_terminal_dumb(void) +{ + const char *terminal = getenv("TERM"); + return !terminal || !strcmp(terminal, "dumb"); So, IIUC, there terminal is considered to be 'dumb' when the TERM environment

Re: [PATCH v4 1/2] refactor "dumb" terminal determination

2017-11-30 Thread Jeff King
On Wed, Nov 29, 2017 at 03:37:51PM +0100, lars.schnei...@autodesk.com wrote: > From: Lars Schneider > > Move the code to detect "dumb" terminals into a single location. This > avoids duplicating the terminal detection code yet again in a subsequent > commit. Makes

[PATCH v4 1/2] refactor "dumb" terminal determination

2017-11-29 Thread lars . schneider
From: Lars Schneider Move the code to detect "dumb" terminals into a single location. This avoids duplicating the terminal detection code yet again in a subsequent commit. Signed-off-by: Lars Schneider --- cache.h| 1 + color.c| 3