Re: [PATCH v4 1/3] tests: move test_lazy_prereq JGIT to test-lib.sh

2016-09-10 Thread Jeff King
On Sat, Sep 10, 2016 at 05:51:19AM +, Torsten Bögershausen wrote: > > +test_lazy_prereq JGIT ' > > + type jgit > > +' > > + > > Minor note: > Typically the stdout of `which` is suppressed like this: > > if ! type cvs >/dev/null 2>&1 But we don't want to suppress the output here; the

Re: [PATCH v4 1/3] tests: move test_lazy_prereq JGIT to test-lib.sh

2016-09-09 Thread Torsten Bögershausen
On Fri, Sep 09, 2016 at 10:36:28AM -0700, Jonathan Tan wrote: [] > diff --git a/t/test-lib.sh b/t/test-lib.sh > index d731d66..c9c1037 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -1072,6 +1072,10 @@ test_lazy_prereq NOT_ROOT ' > test "$uid" != 0 > ' > > +test_lazy_prereq JGIT

[PATCH v4 1/3] tests: move test_lazy_prereq JGIT to test-lib.sh

2016-09-09 Thread Jonathan Tan
This enables JGIT to be used as a prereq in invocations of test_expect_success (and other functions) in other test scripts. Signed-off-by: Jonathan Tan --- t/t5310-pack-bitmaps.sh | 4 t/test-lib.sh | 4 2 files changed, 4 insertions(+), 4