Re: [PATCH v4 1/4] Refactor skipping DOS drive prefixes

2016-01-24 Thread Johannes Schindelin
Hi Hannes, On Sat, 23 Jan 2016, Johannes Sixt wrote: > Am 23.01.2016 um 09:25 schrieb Johannes Schindelin: > > > On Fri, 22 Jan 2016, Junio C Hamano wrote: > > > > > Johannes Sixt writes: > > > > > > > I suggest to move the function definition out of line: > > > > > > > > diff

Re: [PATCH v4 1/4] Refactor skipping DOS drive prefixes

2016-01-24 Thread Johannes Sixt
Am 24.01.2016 um 11:56 schrieb Johannes Schindelin: > $ grep -w isalpha /mingw32/i686-w64-mingw32/include/*.h > /mingw32/i686-w64-mingw32/include/ctype.h: _CRTIMP int __cdecl isalpha(int > _C); > /mingw32/i686-w64-mingw32/include/ctype.h:#define __iscsymf(_c) (isalpha(_c) > || ((_c)=='_')) > >

Re: [PATCH v4 1/4] Refactor skipping DOS drive prefixes

2016-01-24 Thread Junio C Hamano
Johannes Sixt writes: > Am 24.01.2016 um 11:56 schrieb Johannes Schindelin: >> $ grep -w isalpha /mingw32/i686-w64-mingw32/include/*.h >> /mingw32/i686-w64-mingw32/include/ctype.h: _CRTIMP int __cdecl isalpha(int >> _C); >> /mingw32/i686-w64-mingw32/include/ctype.h:#define

Re: [PATCH v4 1/4] Refactor skipping DOS drive prefixes

2016-01-23 Thread Johannes Schindelin
Hi Junio, On Fri, 22 Jan 2016, Junio C Hamano wrote: > Johannes Sixt writes: > > > I suggest to move the function definition out of line: > > > > diff --git a/compat/mingw.c b/compat/mingw.c > > index 10a51c0..0cebb61 100644 > > --- a/compat/mingw.c > > +++ b/compat/mingw.c > >

Re: [PATCH v4 1/4] Refactor skipping DOS drive prefixes

2016-01-23 Thread Johannes Sixt
Am 23.01.2016 um 09:25 schrieb Johannes Schindelin: Hi Junio, On Fri, 22 Jan 2016, Junio C Hamano wrote: Johannes Sixt writes: I suggest to move the function definition out of line: diff --git a/compat/mingw.c b/compat/mingw.c index 10a51c0..0cebb61 100644 ---

Re: [PATCH v4 1/4] Refactor skipping DOS drive prefixes

2016-01-22 Thread Johannes Sixt
Am 12.01.2016 um 08:57 schrieb Johannes Schindelin: > diff --git a/compat/mingw.h b/compat/mingw.h > index 57ca477..b3e5044 100644 > --- a/compat/mingw.h > +++ b/compat/mingw.h > @@ -361,7 +361,15 @@ HANDLE winansi_get_osfhandle(int fd); >* git specific compatibility >*/ > > -#define

Re: [PATCH v4 1/4] Refactor skipping DOS drive prefixes

2016-01-22 Thread Junio C Hamano
Johannes Sixt writes: > I suggest to move the function definition out of line: > > diff --git a/compat/mingw.c b/compat/mingw.c > index 10a51c0..0cebb61 100644 > --- a/compat/mingw.c > +++ b/compat/mingw.c > @@ -1915,6 +1915,13 @@ pid_t waitpid(pid_t pid, int *status, int options)